beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2338: [BEAM-1818] Add PTransform#getAdditionalInputs()
Date Mon, 27 Mar 2017 19:28:28 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2338

    [BEAM-1818] Add PTransform#getAdditionalInputs()

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This permits all PTransforms to expose any input PValues they recieve
    via a side channel. This lets the Pipeline include those inputs as input
    to the PTransform node even when the actual generic PTransform types do
    not include those inputs (e.g. as a Side Input to a ParDo, which is not
    represented in the input PCollection type).
    
    Implement getAdditionalInputs in ParDo and Combine.
    
    getAdditionalInputs is currently unused.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam ptransform_additional_outputs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2338
    
----
commit d4314198869436a2923039938460e62eb9879133
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-22T20:48:57Z

    Add PTransform#getAdditionalInputs()
    
    This permits all PTransforms to expose any input PValues they recieve
    via a side channel. This lets the Pipeline include those inputs as input
    to the PTransform node even when the actual generic PTransform types do
    not include those inputs (e.g. as a Side Input to a ParDo, which is not
    represented in the input PCollection type).
    
    Implement getAdditionalInputs in ParDo and Combine.
    
    getAdditionalInputs is currently unused.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message