beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pabloem <...@git.apache.org>
Subject [GitHub] beam pull request #2317: [BEAM-1803] Fixing bug in Metrics filters. Adding u...
Date Fri, 24 Mar 2017 19:55:36 GMT
GitHub user pabloem opened a pull request:

    https://github.com/apache/beam/pull/2317

    [BEAM-1803] Fixing bug in Metrics filters. Adding unittests.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    r: @aviemzur ┬┐Can you take a look? It should be fairly simple.
    Thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pabloem/incubator-beam fix-filtering

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2317
    
----
commit a53a0f38206f6a93f5e9620773d98c25b9a630c0
Author: Pablo <pabloem@google.com>
Date:   2017-03-24T19:53:10Z

    Unittests for metrics filtering.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message