beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2307: Make WindowMappingFn#maximumLookback Configurable b...
Date Thu, 23 Mar 2017 22:21:00 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2307

    Make WindowMappingFn#maximumLookback Configurable but Final

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This enforces that it return a constant value.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam window_mapping_fun_params

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2307
    
----
commit d9092c980e532dcdd365ae63e4da14e6f92f0e95
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-23T22:20:06Z

    Make WindowMappingFn#maximumLookback Configurable but Final
    
    This enforces that it return a constant value.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message