beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ssisk <...@git.apache.org>
Subject [GitHub] beam pull request #2253: [BEAM-1644] Move PipelineOptions for IO ITs into sh...
Date Wed, 15 Mar 2017 21:55:23 GMT
GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2253

    [BEAM-1644] Move PipelineOptions for IO ITs into shared location.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    * creates a common directory for IO 
    * moves the current pipeline options (which are spread out into separate directories)
into that common directory.
    
    This is is useful/necessary because:
    1. In order to run all the IO ITs in one run, they have to have a shared set of pipeline
options - options on the command line but not present in the PipelineOptions being used to
read them will cause an error
    2. Data stores may be accessed in different IO modules, but should share common command
line options - having them in a common directory makes that easier.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam io-test-pipeline-options

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2253
    
----
commit c5568417876ed6c8ea2e64c6caa22098f4494d41
Author: Stephen Sisk <sisk@google.com>
Date:   2017-03-15T21:31:49Z

    Move PipelineOptions for IO ITs into shared location.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message