beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iemejia <>
Subject [GitHub] beam pull request #2231: [BEAM-923] Add localhost option for DatastoreIO (fi...
Date Mon, 13 Mar 2017 14:58:30 GMT
GitHub user iemejia opened a pull request:

    [BEAM-923] Add localhost option for DatastoreIO (fix assignment issue)

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](

You can merge this pull request into a Git repository by running:

    $ git pull BEAM-923-localhost-for-datastore

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2231
commit eb7b5dd6c218f19f000119baf4ff330dac970748
Author: Ismaël Mejía <>
Date:   2017-03-13T12:49:38Z

    [BEAM-923] Improve DatastoreV1 tests to detect wrong localhost assignment

commit 39ff12a24c2f03648f381aa4916efad7417f137b
Author: Ismaël Mejía <>
Date:   2017-03-13T12:58:50Z

    [BEAM-923] Refactor DatastoreV1 Mutate to fix the issue with localhost assignment


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message