beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kennknowles <...@git.apache.org>
Subject [GitHub] beam pull request #2226: [BEAM-1690] Revert BigQueryIO bit of 'Make all uses...
Date Sat, 11 Mar 2017 03:04:43 GMT
GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2226

    [BEAM-1690] Revert BigQueryIO bit of 'Make all uses of CountingOutputStream close their
resources'

    This reverts the portion of commit 3115dbdca1858511e98476b5c79e6cca98782b0b
    that touches BigQueryIO, which caused a double close bug, seen here: https://builds.apache.org/job/beam_PostCommit_Java_MavenInstall/org.apache.beam$beam-examples-java/2857/testReport/junit/org.apache.beam.examples.cookbook/BigQueryTornadoesIT/testE2EBigQueryTornadoes/

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam BigQueryTornadoesIT

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2226
    
----
commit 598c24e1fc2cf607d9fd01dd07ceca7ea97da84a
Author: Kenneth Knowles <klk@google.com>
Date:   2017-03-11T03:01:23Z

    Revert BigQueryIO bit of 'Make all uses of CountingOutputStream close their resources'
    
    This reverts the portion of commit 3115dbdca1858511e98476b5c79e6cca98782b0b
    that touches BigQueryIO, which caused a double close bug.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message