beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] beam pull request #2217: [BEAM-1674] Fix Flink State GC
Date Fri, 10 Mar 2017 10:11:16 GMT
GitHub user aljoscha opened a pull request:

    https://github.com/apache/beam/pull/2217

    [BEAM-1674] Fix Flink State GC

    This is a proper solution, as discussed in the Jira issue. If we merge this we can drop
#2215. (Thanks for quickly providing that PR, though!)
    
    R: @kennknowles 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/beam jira-1674-fix-flink-gc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2217
    
----
commit bf6d2748c8876a7415290069163625598928f02f
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-03-10T07:29:27Z

    Move GC timer checking to StatefulDoFnRunner.CleanupTimer

commit 1a8e1f7463cbc7c6b5edfe1dbbc98502e5612511
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-03-10T10:07:00Z

    Introduce Flink-specific state GC implementations
    
    We now set the GC timer for window.maxTimestamp() + 1 to ensure that a
    user timer set for window.maxTimestamp() still has all state.
    
    This also adds tests for late data dropping and state GC specifically
    for the Flink DoFnOperator.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message