beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertwb <...@git.apache.org>
Subject [GitHub] beam pull request #2214: Ensure that assert_that takes a PCollection as its ...
Date Fri, 10 Mar 2017 00:23:27 GMT
GitHub user robertwb opened a pull request:

    https://github.com/apache/beam/pull/2214

    Ensure that assert_that takes a PCollection as its first argument.

    This can avoid (silent) error such as
    
        with test_pipeline.TestPipeline() as p:
          bad_value = "Create0" >> beam.Create([1])  # Note missing "p | "
          beam_util.assert_that(bad_value, beam_util.equal_to([0]))
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertwb/incubator-beam assert-that

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2214
    
----
commit 479cc0181daa3b98ef6ccdc8c3c1512bc2e3efae
Author: Robert Bradshaw <robertwb@gmail.com>
Date:   2017-03-10T00:18:46Z

    Ensure that assert_that takes a PCollection as its first argument.
    
    This can avoid (silent) error such as
    
        with test_pipeline.TestPipeline() as p:
          bad_value = "Create0" >> beam.Create([1])  # Note missing "p | "
          beam_util.assert_that(bad_value, beam_util.equal_to([0]))

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message