beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davorbonaci <...@git.apache.org>
Subject [GitHub] beam pull request #2182: Add ServicesResourceTransformer to all shading conf...
Date Tue, 07 Mar 2017 20:00:39 GMT
GitHub user davorbonaci opened a pull request:

    https://github.com/apache/beam/pull/2182

    Add ServicesResourceTransformer to all shading configuration

    This ensures that files in META-INF/services aren't overwritten. Instead, they are concatenated.
    
    This is critical to ensure PipelineOptionsRegistrar, RunnerRegistrar, IOChannelFactoryRegistrar
    and FileSystemRegistrar work well for users.
    
    R: @aviemzur
    CC: @francesperry (this is precluding `--flinkMaster` and other Flink-specific pipeline
options from working in a bundled JAR)
    CC: @aaltay, we should cherry-pick this into the release in-progress.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davorbonaci/beam shade-services

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2182
    
----
commit d3dc0f683401e63de05ddce3210680a2d67a666e
Author: Davor Bonaci <davor@google.com>
Date:   2017-03-07T19:57:38Z

    Add ServicesResourceTransformer to all shading configuration
    
    This ensures that files in META-INF/services aren't overwritten. Instead, they are concatenated.
    
    This is critical to ensure PipelineOptionsRegistrar, RunnerRegistrar, IOChannelFactoryRegistrar
    and FileSystemRegistrar work well for users.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message