beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1842) Stop matching composite PCollectionView PTransforms
Date Thu, 30 Mar 2017 18:26:42 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949548#comment-15949548
] 

ASF GitHub Bot commented on BEAM-1842:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2373

    [BEAM-1842] Add CreateViewWithViewFn PTransformMatcher

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---   
    This matcher is to stop matching the composite View.asFoo PTransforms,
    as a PipelineRunner should support materialization of arbitrary
    PTransforms created with the CreatePCollectionView transform.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam stop_view_asFoo_overrides

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2373
    
----
commit e0887a011484368139700259eb5af0363c5cbc4d
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-30T17:47:12Z

    Include the creating PCollection in PCollectionView
    
    This is available on the client that created the view, but may not be
    available elsewhere.
    
    Update signatures and callers to match.

commit add1e64e99b4b991ecf2fa8233f50dfbaabdffc6
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-30T18:21:19Z

    Add CreateViewWithViewFn PTransformMatcher
    
    This matcher is to stop matching the composite View.asFoo PTransforms,
    as a PipelineRunner should support materialization of arbitrary
    PTransforms created with the CreatePCollectionView transform.

----


> Stop matching composite PCollectionView PTransforms
> ---------------------------------------------------
>
>                 Key: BEAM-1842
>                 URL: https://issues.apache.org/jira/browse/BEAM-1842
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> This should be part of enabling materialization of arbitrary ViewFns.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message