beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1773) Consider allowing Source#validate() to throw exception
Date Tue, 21 Mar 2017 18:51:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935113#comment-15935113
] 

Kenneth Knowles commented on BEAM-1773:
---------------------------------------

What is the goal? It is extremely unlikely that the caller can respond in any useful way to
the validate failing.

> Consider allowing Source#validate() to throw exception
> ------------------------------------------------------
>
>                 Key: BEAM-1773
>                 URL: https://issues.apache.org/jira/browse/BEAM-1773
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Ted Yu
>            Assignee: Jean-Baptiste Onofré
>
> In HDFSFileSource.java :
> {code}
>   @Override
>   public void validate() {
> ...
>       } catch (IOException | InterruptedException e) {
>         throw new RuntimeException(e);
>       }
> {code}
> Source#validate() should be allowed to throw exception so that we don't resort to using
RuntimeException.
> Here was related thread on mailing list:
> http://search-hadoop.com/m/Beam/gfKHFOwE0uETxae?subj=Re+why+Source+validate+is+not+declared+to+throw+any+exception



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message