beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1760) Potential null dereference in HDFSFileSink#doFinalize
Date Tue, 28 Mar 2017 23:35:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946210#comment-15946210
] 

Ted Yu commented on BEAM-1760:
------------------------------

[~davor]:
Can you take a look at the PR ?

> Potential null dereference in HDFSFileSink#doFinalize
> -----------------------------------------------------
>
>                 Key: BEAM-1760
>                 URL: https://issues.apache.org/jira/browse/BEAM-1760
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>       for (FileStatus s : statuses) {
>         String name = s.getPath().getName();
>         int pos = name.indexOf('.');
>         String ext = pos > 0 ? name.substring(pos) : "";
>         fs.rename(
>             s.getPath(),
>             new Path(s.getPath().getParent(), String.format("part-r-%05d%s", i, ext)));
>         i++;
>       }
>     }
> {code}
> We should check whether s.getPath().getParent() is null.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message