beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1742) UnboundedSource CheckpointMark should have more precise documentation
Date Fri, 17 Mar 2017 18:09:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930399#comment-15930399
] 

ASF GitHub Bot commented on BEAM-1742:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2266

    [BEAM-1742] Update Checkpoint and Finalize Documentation

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This more precisely specifies how a runner is permitted to interact with
    a CheckpointMark, and the requirements on implementors for what a source
    must be capable of handling.
    
    Existing CheckpointMarks should be audited to ensure that they meet
    these new requirements.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam finalize_spec

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2266
    
----
commit 1800a16af4e7af5e6b5e97b1fe90900f555ce540
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-14T17:47:50Z

    Update Checkpoint and Finalize Documentation
    
    This more precisely specifies how a runner is permitted to interact with
    a CheckpointMark, and the requirements on implementors for what a source
    must be capable of handling.
    
    Existing CheckpointMarks should be audited to ensure that they meet
    these new requirements.

----


> UnboundedSource CheckpointMark should have more precise documentation
> ---------------------------------------------------------------------
>
>                 Key: BEAM-1742
>                 URL: https://issues.apache.org/jira/browse/BEAM-1742
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> It should describe when a Checkpoint can committed, and should have more precise definitions
of when a runner is permitted to finalize it.
> Generally these definitions are more forgiving than what some checkpoints assume, so
existing Unbounded Sources should be audited to ensure they behave correctly in this context.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message