beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aviem Zur (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-1692) Convert to Codahale Metric interfaces where possible in WithMetricsSupport MetricRegistry
Date Sat, 11 Mar 2017 15:02:04 GMT

     [ https://issues.apache.org/jira/browse/BEAM-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Aviem Zur updated BEAM-1692:
----------------------------
    Description: 
Currently in Spark runner all Beam metrics are reported by Codahale metrics as Codahale {{Gauge}}
metrics.
Some of the metrics are formatted to look like their counterparts in Codahale's {{GraphiteReporter}}
but this is a hack and should be avoided if possible.

Instead, convert Beam metrics to their Codahale counterparts in {{WithMetricsSupport}} getters
where possible.

Since Beam metrics are not 100% compatible with Codahale metrics, consider where to make tradeoffs
and stay with a simple {{Gauge}}.

Also, rename {{WithMetricsSupport}} something like {{SparkBeamMetricRegistry}}

  was:
Currently in Spark runner all Beam metrics are reported by Codahale metrics as Codahale {{Gauge}}s.
Some of the metrics are formatted to look like their counterparts in Codahale's {{GraphiteReporter}}
but this is a hack and should be avoided if possible.

Instead, convert Beam metrics to their Codahale counterparts in {{WithMetricsSupport}} getters
where possible.

Since Beam metrics are not 100% compatible with Codahale metrics, consider where to make tradeoffs
and stay with a simple {{Gauge}}.

Also, rename {{WithMetricsSupport}} something like {{SparkBeamMetricRegistry}}


> Convert to Codahale Metric interfaces where possible in WithMetricsSupport MetricRegistry
> -----------------------------------------------------------------------------------------
>
>                 Key: BEAM-1692
>                 URL: https://issues.apache.org/jira/browse/BEAM-1692
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-spark
>            Reporter: Aviem Zur
>            Assignee: Aviem Zur
>            Priority: Minor
>
> Currently in Spark runner all Beam metrics are reported by Codahale metrics as Codahale
{{Gauge}} metrics.
> Some of the metrics are formatted to look like their counterparts in Codahale's {{GraphiteReporter}}
but this is a hack and should be avoided if possible.
> Instead, convert Beam metrics to their Codahale counterparts in {{WithMetricsSupport}}
getters where possible.
> Since Beam metrics are not 100% compatible with Codahale metrics, consider where to make
tradeoffs and stay with a simple {{Gauge}}.
> Also, rename {{WithMetricsSupport}} something like {{SparkBeamMetricRegistry}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message