beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1674) Flink user state GC depends on order of timer firing
Date Fri, 10 Mar 2017 04:27:38 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904418#comment-15904418
] 

ASF GitHub Bot commented on BEAM-1674:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2215

    [BEAM-1674] Exclude UsesTimersInParDo from Flink validation test suite

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @aljoscha @JingsongLi 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam flink-timers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2215
    
----
commit 43d91a05c4df395ff6146984cb5f0a8fa772f09b
Author: Kenneth Knowles <klk@google.com>
Date:   2017-03-10T04:26:52Z

    Exclude UsesTimersInParDo from Flink validation test suite

----


> Flink user state GC depends on order of timer firing
> ----------------------------------------------------
>
>                 Key: BEAM-1674
>                 URL: https://issues.apache.org/jira/browse/BEAM-1674
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>    Affects Versions: 0.5.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 0.6.0
>
>
> The newly added {{ParDoTest.testEventTimeTimerMultipleKeys()}} fails because the {{DoFn}}
sets a timer for {{window.maxTimestamp()}} which also happens to be the GC timer for the user
state. The Flink Runner uses timers to schedule GC, the user-set timer and the GC timer have
a different timer id, so they don't clash. However, if the GC timer is being processed before
the user timer then the user doesn't have a chance to access the state anymore because it
will already be cleared out by the time the user timer is being processed. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message