beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1657) DirectRunner should not call close twice in UnboundedSourceExecutorFactory
Date Tue, 14 Mar 2017 17:47:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924673#comment-15924673
] 

ASF GitHub Bot commented on BEAM-1657:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2242


> DirectRunner should not call close twice in UnboundedSourceExecutorFactory
> --------------------------------------------------------------------------
>
>                 Key: BEAM-1657
>                 URL: https://issues.apache.org/jira/browse/BEAM-1657
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Ben Chambers
>            Assignee: Thomas Groh
>             Fix For: First stable release
>
>
> At the end of the processElement, in `finishRead` there is a 5% chance we decide to `close`
the reader. If the call to {{close}} throws an {{IOException}}, it will propagate that exception
back to the call to {{processElement}}, which will attempt to {{close}} the reader again,
which violates the {{AutoCloseable}} spec.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message