beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Chambers (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-1656) DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory
Date Thu, 09 Mar 2017 04:16:38 GMT

     [ https://issues.apache.org/jira/browse/BEAM-1656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ben Chambers updated BEAM-1656:
-------------------------------

Even then, we shouldn't call finalize before finishing using the restored
instance, I think.




> DirectRunner should not call finalize twice in UnboundedSourceExecutorFactory
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-1656
>                 URL: https://issues.apache.org/jira/browse/BEAM-1656
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Ben Chambers
>            Assignee: Thomas Groh
>
> In [getReader](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L174)
we call finalize on the checkpoint that arrived in the incoming shard. Then later in [finishRead](https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java#L205)
we finalize the old checkpoint again.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message