beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1633) Move .tox/ directory under target/ in Python SDK
Date Tue, 07 Mar 2017 13:03:38 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899391#comment-15899391
] 

ASF GitHub Bot commented on BEAM-1633:
--------------------------------------

GitHub user tibkiss opened a pull request:

    https://github.com/apache/beam/pull/2179

    [BEAM-1633] Move .tox/ directory under target/ in Python SDK

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tibkiss/beam BEAM-1633

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2179
    
----
commit 6cc80daf745cc77d779ee5a8494e97552fe02c0a
Author: Tibor Kiss <tibor.kiss@gmail.com>
Date:   2017-03-07T12:42:34Z

    [BEAM-1633] Move .tox/ directory under target/ in Python SDK

----


> Move .tox/ directory under target/ in Python SDK
> ------------------------------------------------
>
>                 Key: BEAM-1633
>                 URL: https://issues.apache.org/jira/browse/BEAM-1633
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Tibor Kiss
>            Assignee: Tibor Kiss
>            Priority: Minor
>
> Beam uses Maven to initiate the build / test process for all components and the Python
SDK relies on Tox to create the test environment. 
> Tox's workdir is currently placed under beam/sdks/python/.tox, which is not located in
Maven's default build output (target/) directory.
>  
> Due to the current directory layout maven does not remove Tox  workdir during {{mvn clean}}.
> Proposed fix: move .tox directory under beam/sdks/python/target directory.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message