beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1611) Stateful ParDo broken in Dataflow batch
Date Wed, 08 Mar 2017 21:09:38 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901973#comment-15901973
] 

ASF GitHub Bot commented on BEAM-1611:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/2198

    [BEAM-1611] Explicitly GBK before stateful ParDo in Dataflow batch

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @aaltay 
    
    This is a cherry-pick of the principle change from #2147. It requires a compatible Dataflow
worker, which I will add here when ready.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam batch-state-0.6.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2198
    
----
commit 035b6f6b87c112213d040b7b8cbb08e446c7d7a5
Author: Kenneth Knowles <klk@google.com>
Date:   2017-03-02T22:29:56Z

    Explicitly GBK before stateful ParDo in Dataflow batch

----


> Stateful ParDo broken in Dataflow batch
> ---------------------------------------
>
>                 Key: BEAM-1611
>                 URL: https://issues.apache.org/jira/browse/BEAM-1611
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Blocker
>             Fix For: 0.6.0
>
>
> The needed shuffle is not performed in batch mode. Confirmed that it is performed in
streaming.
> http://stackoverflow.com/questions/42564604/stateful-pardo-not-working-on-dataflow-runner/42566967#42566967
> Filing here as the quickest fix is to work around with transform overrides in Beam, analogous
to those in the direct runner.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message