beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1582) ResumeFromCheckpointStreamingTest flakes with what appears as a second firing.
Date Mon, 06 Mar 2017 12:56:32 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897224#comment-15897224
] 

ASF GitHub Bot commented on BEAM-1582:
--------------------------------------

GitHub user amitsela opened a pull request:

    https://github.com/apache/beam/pull/2168

    [BEAM-1582, BEAM-1562] Stop streaming tests on EOT Watermark.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amitsela/beam stop-streaming-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2168
    
----
commit 7d171bf5a69e6eb3f7ae58343a06c4a48865feaf
Author: Sela <ansela@paypal.com>
Date:   2017-03-04T19:04:02Z

    Test runner to stop on EOT watermark, or timeout.

commit 899021fa4bf969c93288379bf847dd7c06ec5f09
Author: Sela <ansela@paypal.com>
Date:   2017-03-04T19:05:25Z

    Remove timeout since it is already a pipeline option.

commit 6b8a37f66cd4a0ca29d5343f3dffbd95202ecb6f
Author: Sela <ansela@paypal.com>
Date:   2017-03-04T19:07:16Z

    Advance to infinity at the end of pipelines.

commit 909201ae2f1bca762fcdd56c0db3bb1841965b54
Author: Sela <ansela@paypal.com>
Date:   2017-03-04T19:07:59Z

    Add EOT watermark and expected assertions test options.

commit e4f66dfb13feea93b0b4c797620c3fa9080652f0
Author: Sela <ansela@paypal.com>
Date:   2017-03-04T19:09:38Z

    SparkPipelineResult should avoid returning null, and handle exceptions better.

commit 73cfebd770fd4b5c6566051172b3e31faaf2c4e9
Author: Sela <ansela@paypal.com>
Date:   2017-03-04T19:11:36Z

    Make ResumeFromCheckpointStreamingTest use TestSparkRunner and stop on EOT watermark.

commit d71207a75ef38dcdbf893fa032753db2875e4d3b
Author: Sela <ansela@paypal.com>
Date:   2017-03-04T20:08:05Z

    fixup! post-rebase import order.

commit 4d1222f2cc653d31bc4cfa5e516af08b5e5e53a6
Author: Sela <ansela@paypal.com>
Date:   2017-03-05T10:52:58Z

    Stop the context and update the state BEFORE throwing the exception.

----


> ResumeFromCheckpointStreamingTest flakes with what appears as a second firing.
> ------------------------------------------------------------------------------
>
>                 Key: BEAM-1582
>                 URL: https://issues.apache.org/jira/browse/BEAM-1582
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Amit Sela
>
> See: https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_MavenInstall/org.apache.beam$beam-runners-spark/2788/testReport/junit/org.apache.beam.runners.spark.translation.streaming/ResumeFromCheckpointStreamingTest/testWithResume/
> After some digging in it appears that a second firing occurs (though only one is expected)
but it doesn't come from a stale state (state is empty before it fires).
> Might be a retry happening for some reason, which is OK in terms of fault-tolerance guarantees
(at-least-once), but not so much in terms of flaky tests. 
> I'm looking into this hoping to fix this ASAP.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message