beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1578) Runners should put PT overrides into a list rather than map
Date Thu, 30 Mar 2017 18:22:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949541#comment-15949541
] 

Kenneth Knowles commented on BEAM-1578:
---------------------------------------

+1 to this little cleanup. While {{ImmutableMap}} has a defined order, it shouldn't be used
as a "list of pairs" data structure. Especially once upcast to {{Map}}.

> Runners should put PT overrides into a list rather than map
> -----------------------------------------------------------
>
>                 Key: BEAM-1578
>                 URL: https://issues.apache.org/jira/browse/BEAM-1578
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow, runner-direct
>            Reporter: Eugene Kirpichov
>            Priority: Minor
>
> It was not clear to me from the code that order of overrides is important. Map is not
the best data structure for this, especially since no key lookups happen.
> Referring to
> https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
> and
> https://github.com/apache/beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java
> and possibly others.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message