beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1427) BigQueryIO should comply with PTransform style guide
Date Fri, 03 Mar 2017 04:23:45 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893721#comment-15893721
] 

ASF GitHub Bot commented on BEAM-1427:
--------------------------------------

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/2149

    [BEAM-1427] BigQueryIO should comply with PTransform style guide

    Main (backward incompatible) changes:
    - Classes BigQueryIO.Read.Bound and Write.Bound are now called simply BigQueryIO.Read
and Write.
    - Previously all parameters could be specified both via static and non-static methods.
Now, BigQueryIO.Read.from() and BigQueryIO.Write.to() are now the only static factory methods
(and they are available _only_ as static methods), and all other methods are non-static.
    
    A bunch of code is saved by using AutoValue.
    
    R: @tgroh  
    CC: @dhalperi @sammcveety (Sam FYI - I think there shouldn't be too many conflicts with
your PR)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam bqio-style

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2149
    
----
commit d16fcda5862a9ce488911871edfc7352a49b5ab3
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-03-03T01:15:47Z

    Condensed BigQueryIO.Read.Bound into BigQueryIO.Read

commit 177f38b55d5e62f039f324b2e667cba9ba6baf22
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-03-03T01:26:09Z

    Condensed BigQueryIO.Write.Bound into BigQueryIO.Write

commit 3b500d75fe8f7b9b7f454683f605dc42da441bc3
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-03-03T01:54:55Z

    Removed two unused fields

commit 014bfccb925aaf93dada82c5e1e8fb188538bed2
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-03-03T01:51:04Z

    Uses AutoValue for BigQueryIO.Read

commit 7859822559dd6c0016a389f1222719acb17433da
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-03-03T02:14:39Z

    Uses AutoValue for BigQueryIO.Write

commit ad72c07908eb88a845011c6cd56dd302eaf21b62
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-03-03T02:19:51Z

    Simplifies configuration of StreamWithDedup

commit 554cddc5c0ab0f380af477989f040d94c9a28ffb
Author: Eugene Kirpichov <kirpichov@google.com>
Date:   2017-03-03T04:05:01Z

    Makes NameUtils recognize AutoValue classes

----


> BigQueryIO should comply with PTransform style guide
> ----------------------------------------------------
>
>                 Key: BEAM-1427
>                 URL: https://issues.apache.org/jira/browse/BEAM-1427
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-gcp
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>              Labels: backward-incompatible
>
> Suggested changes:
> - Remove Read/Write.Bound classes - Read and Write themselves should be the transform
classes
> - Remove static builder-like .withBlah() methods
> - (optional) use AutoValue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message