beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1425) Window should comply with PTransform style guide
Date Thu, 09 Mar 2017 19:31:38 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903701#comment-15903701
] 

Kenneth Knowles commented on BEAM-1425:
---------------------------------------

But we should still get rid of {{Bound}} and likely use autovalue.

> Window should comply with PTransform style guide
> ------------------------------------------------
>
>                 Key: BEAM-1425
>                 URL: https://issues.apache.org/jira/browse/BEAM-1425
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Davor Bonaci
>              Labels: backward-incompatible
>
> Suggested changes:
> - Remove static builder-like methods such as triggering(), discardingFiredPanes() - the
only static entry point should be .into().
> - (optional) use AutoValue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message