beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Kirpichov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1417) Count should comply with PTransform style guide
Date Wed, 01 Mar 2017 06:19:45 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15889575#comment-15889575
] 

Eugene Kirpichov commented on BEAM-1417:
----------------------------------------

Actual backward-incompatible changes made: 
Made classes Count.PerElement, PerKey, Globally inaccessible so you:
- have to use the factory functions
- if you want to e.g. use .withHotKeyFanout() or whatnot, then you have to apply Combine.globally(Count.combineFn())
yourself.

> Count should comply with PTransform style guide
> -----------------------------------------------
>
>                 Key: BEAM-1417
>                 URL: https://issues.apache.org/jira/browse/BEAM-1417
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Eugene Kirpichov
>            Assignee: Eugene Kirpichov
>              Labels: backward-incompatible
>             Fix For: 0.6.0
>
>
> Suggested change (backward-compatible): methods globally(), perKey(), perElement() should
return respective transform classes - Count.Globally, Count.PerKey, Count.PerElement. (currently
some of them return a PTransform which is actually a Combine - the suggestion is to wrap them
into classes).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message