beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1327) Replace OutputTimeFn with enum
Date Thu, 23 Mar 2017 06:22:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937807#comment-15937807
] 

Kenneth Knowles commented on BEAM-1327:
---------------------------------------

Noting that the first step is already in progress - converting to/from an enum as part of
the Runner API. This should make it easy to go all the way and have the user provide an enum
while runners/core-java provides implementations copied from today's logic. Basically the
same transition as triggers.

> Replace OutputTimeFn with enum
> ------------------------------
>
>                 Key: BEAM-1327
>                 URL: https://issues.apache.org/jira/browse/BEAM-1327
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Minor
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>
> The class {{OutputTimeFn}} is overkill for a Fn API crossing. There are only three sensible
values known: MIN, MAX, EOW. The interface is right for implementing these, but the full class
is left over from the days when there was little cost to shipping new kinds of fns. An enum
is concise.
> This can be done "mostly" backwards compatibly with legacy adapters in place, but might
be less confusing without them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message