beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1182) Direct runner should enforce encodability of unbounded source checkpoints
Date Fri, 24 Mar 2017 23:46:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941342#comment-15941342
] 

ASF GitHub Bot commented on BEAM-1182:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2323


> Direct runner should enforce encodability of unbounded source checkpoints
> -------------------------------------------------------------------------
>
>                 Key: BEAM-1182
>                 URL: https://issues.apache.org/jira/browse/BEAM-1182
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Eugene Kirpichov
>            Assignee: Thomas Groh
>
> As far as I can tell, https://github.com/apache/incubator-beam/blob/master/runners/direct-java/src/main/java/org/apache/beam/runners/direct/UnboundedReadEvaluatorFactory.java
currently uses the reader's getCheckpoint() only as an in-memory object, i.e. it's not exercising
that 1) the checkpoint can be encoded at all, and 2) that the reader can be resumed from an
encoded/decoded checkpoint.
> I've seen cases in code reviews where people implemented a non-serializable checkpoint,
and direct runner tests didn't catch that because of this issue.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message