beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-846) Decouple side input window mapping from WindowFn
Date Tue, 21 Mar 2017 16:50:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934870#comment-15934870
] 

ASF GitHub Bot commented on BEAM-846:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2284

    [BEAM-846] Add WindowMappingFn, WindowMappingFns

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    WindowMappingFn maps from a main input window to a side input window,
    and provides a maximum amount of lookback that is possible to generate
    using the MappingFn. This separates the logic of assigning windows from
    the logic of mapping main and side inputs. Additionally, it permits
    pipeline runners to garbage collect side inputs when they are no longer
    accessible.
    
    This is currently unused.
    
    See BEAM-846 and BEAM-260 for additional context.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam window_mapping_fn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2284
    
----
commit 44d70b0b9d50f261667d49cf456ccb9a49b2bec0
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-21T16:46:04Z

    Add WindowMappingFn, WindowMappingFns
    
    WindowMappingFn maps from a main input window to a side input window,
    and provides a maximum amount of lookback that is possible to generate
    using the MappingFn. This separates the logic of assigning windows from
    the logic of mapping main and side inputs. Additionally, it permits
    pipeline runners to garbage collect side inputs when they are no longer
    accessible.
    
    This is currently unused.
    
    See BEAM-846 and BEAM-260 for additional context.

----


> Decouple side input window mapping from WindowFn
> ------------------------------------------------
>
>                 Key: BEAM-846
>                 URL: https://issues.apache.org/jira/browse/BEAM-846
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model-runner-api, sdk-java-core
>            Reporter: Robert Bradshaw
>            Assignee: Thomas Groh
>              Labels: backward-incompatible
>             Fix For: First stable release
>
>
> Currently the main WindowFn provides as getSideInputWindow method. Instead, this mapping
should be specified per-side-input (thought the default mapping would remain the same). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message