beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tibor Kiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-778) Make fileio._CompressedFile seekable.
Date Wed, 29 Mar 2017 19:20:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947739#comment-15947739
] 

Tibor Kiss commented on BEAM-778:
---------------------------------

Thanks for the insights, [~katsiapis@google.com] & [~chamikara].

As there is no immediate risk of concurrency issue I'd also opt for not extending _CompressedFile
with a lock prematurely.
I'll make a comment about the (lack of) thread safety in _CompressedFile in the PR associated
with this JIRA.

> Make fileio._CompressedFile seekable.
> -------------------------------------
>
>                 Key: BEAM-778
>                 URL: https://issues.apache.org/jira/browse/BEAM-778
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Tibor Kiss
>             Fix For: Not applicable
>
>
> We have a TODO to make fileio._CompressedFile seekable.
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/io/fileio.py#L692
> Without this, compressed file objects produce for FileBasedSource implementations may
not be able to use libraries that utilize methods seek() and tell().
> For example tarfile.open().



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message