beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantinos Katsiapis (JIRA)" <>
Subject [jira] [Commented] (BEAM-778) Make fileio._CompressedFile seekable.
Date Fri, 24 Mar 2017 18:34:41 GMT


Konstantinos Katsiapis commented on BEAM-778:

Yes, when I had looked at that in the past, it was very easy to use gzip.GzipFile(..., fileobj
= self._file, ...) [1] but unfortunately not so for Bzip2 [2] or Snappy [3]. And we wanted
to share as much implementation as possible (as opposed to have completely different codepaths
for each compression type).

Provided that we can have a single interface that allows us to handle Gzip/Bzip2 (and ideally
in the future Snappy and other whole-file compression techniques) with minimal diffs, changing
the underlying implementation is I think fair game.

[1] and

> Make fileio._CompressedFile seekable.
> -------------------------------------
>                 Key: BEAM-778
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Tibor Kiss
>             Fix For: Not applicable
> We have a TODO to make fileio._CompressedFile seekable.
> Without this, compressed file objects produce for FileBasedSource implementations may
not be able to use libraries that utilize methods seek() and tell().
> For example

This message was sent by Atlassian JIRA

View raw message