beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-772) Implement Metrics support for Dataflow Runner
Date Wed, 22 Mar 2017 20:28:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937064#comment-15937064
] 

ASF GitHub Bot commented on BEAM-772:
-------------------------------------

GitHub user pabloem opened a pull request:

    https://github.com/apache/beam/pull/2290

    [BEAM-772] Querying of both structured and unstructured metrics in Dataflow.

    This allows for metrics querying to work with structured names and unstructured names
alike. It's been tested in both cases.
    R: @charlesccychen 
    Question: Do you think that `_translate_step_name` should be part of `DataflowMetrics`?
Or should this function be available somewhere else in the `DataflowRunner` or `apiclient.Job`
classes, so that other components can use it?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pabloem/incubator-beam query-structured-python

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2290
    
----
commit 5967a3c7807ddf0c308d52b60c4840eae6414904
Author: Pablo <pabloem@google.com>
Date:   2017-03-22T20:22:32Z

    Querying of both structured and unstructured metrics in dataflow.

commit 5b28c7d75ff32bc86166d12f5b796285523a80bf
Author: Pablo <pabloem@google.com>
Date:   2017-03-22T20:27:48Z

    Adding PyDoc

----


> Implement Metrics support for Dataflow Runner
> ---------------------------------------------
>
>                 Key: BEAM-772
>                 URL: https://issues.apache.org/jira/browse/BEAM-772
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-dataflow
>            Reporter: Ben Chambers
>            Assignee: Ben Chambers
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message