beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-632) Dataflow runner does not correctly flatten duplicate inputs
Date Fri, 24 Mar 2017 22:58:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941303#comment-15941303
] 

ASF GitHub Bot commented on BEAM-632:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2325

    [BEAM-632] Fix Flatten PCollections in Dataflow

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam dataflow_flatten

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2325
    
----
commit 086d95f78e3188ea0036f3c4db7979e204775e4c
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-24T22:38:20Z

    Fix EmptyFlattenAsCreateFactory
    
    The input types of Flatten and Create don't match up, so a composite
    must be provided instead of Create directly.

commit 3982110f20e17f6022ec30d1ecb44e47653f12bb
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-24T21:45:08Z

    Reenable Flatten Tests in the Dataflow Runner

commit 125c4b09639e60ad3be5b34131185806b07b6b5f
Author: Thomas Groh <tgroh@google.com>
Date:   2017-03-24T22:14:27Z

    Explicitly duplicate input PCollections in Dataflow

----


> Dataflow runner does not correctly flatten duplicate inputs
> -----------------------------------------------------------
>
>                 Key: BEAM-632
>                 URL: https://issues.apache.org/jira/browse/BEAM-632
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Daniel Halperin
>            Assignee: Thomas Groh
>            Priority: Critical
>             Fix For: First stable release
>
>
> https://github.com/apache/incubator-beam/pull/960
> Builds #1148+ are failing the new test that [~tgroh] added in that PR.
> https://builds.apache.org/job/beam_PostCommit_RunnableOnService_GoogleCloudDataflow/changes



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message