beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Groh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-576) ReduceFnRunner should GC based on current WM, not on a fired Timer
Date Thu, 23 Mar 2017 15:55:41 GMT

    [ https://issues.apache.org/jira/browse/BEAM-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938618#comment-15938618
] 

Thomas Groh commented on BEAM-576:
----------------------------------

Yes. Additionally, if we don't set a GC timer we won't promptly expire a window that is expired
and flush any remaining output.

> ReduceFnRunner should GC based on current WM, not on a fired Timer
> ------------------------------------------------------------------
>
>                 Key: BEAM-576
>                 URL: https://issues.apache.org/jira/browse/BEAM-576
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Priority: Minor
>
> ReduceFnRunner currently uses the time of a timer to determine if it is the garbage collection
timer. Instead, it should examine the time a window is expired and the current input watermark
to determine if the window should be Garbage Collected. It should additionally ignore all
timers for windows that have already been expired.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message