beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pabloem <>
Subject [GitHub] beam pull request #2290: [BEAM-772] Querying of both structured and unstruct...
Date Wed, 22 Mar 2017 21:18:01 GMT
GitHub user pabloem reopened a pull request:

    [BEAM-772] Querying of both structured and unstructured metrics in Dataflow.

    This allows for metrics querying to work with structured names and unstructured names
alike. It's been tested in both cases.
    R: @charlesccychen 
    Question: Do you think that `_translate_step_name` should be part of `DataflowMetrics`?
Or should this function be available somewhere else in the `DataflowRunner` or `apiclient.Job`
classes, so that other components can use it?

You can merge this pull request into a Git repository by running:

    $ git pull query-structured-python

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2290
commit 5967a3c7807ddf0c308d52b60c4840eae6414904
Author: Pablo <>
Date:   2017-03-22T20:22:32Z

    Querying of both structured and unstructured metrics in dataflow.

commit 5b28c7d75ff32bc86166d12f5b796285523a80bf
Author: Pablo <>
Date:   2017-03-22T20:27:48Z

    Adding PyDoc

commit 661f19bee5bb9745de460bd2f4302c3f1c682648
Author: Pablo <>
Date:   2017-03-22T21:07:14Z

    Fixing lint issues.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message