Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Thu, 9 Feb 2017 17:42:41 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13041468.1486583758000.40528.1486662161986@Atlassian.JIRA>
In-Reply-To: <JIRA.13041468.1486583758000@Atlassian.JIRA>
References: <JIRA.13041468.1486583758000@Atlassian.JIRA> <JIRA.13041468.1486583758971@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-1437) Spark runner StreamingListeners are
 not recoverable.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 09 Feb 2017 17:42:55 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859881#comment-15859881 ] 

ASF GitHub Bot commented on BEAM-1437:
--------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/beam/pull/1962

    [BEAM-1437] Spark runner StreamingListeners are not recoverable.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/beam recoverable-spark-runner-streaming-listeners

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1962.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1962
    
----
commit 791a31f6b434a3b55ea48d4a17a46503fcc9087e
Author: Aviem Zur <aviemzur@gmail.com>
Date:   2017-02-09T17:40:31Z

    [BEAM-1437] Spark runner StreamingListeners are not recoverable.

----


> Spark runner StreamingListeners are not recoverable.
> ----------------------------------------------------
>
>                 Key: BEAM-1437
>                 URL: https://issues.apache.org/jira/browse/BEAM-1437
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Amit Sela
>            Assignee: Aviem Zur
>
> Spark runner registers user-provided StreamingListeners in {{SparkRunnerStreamingContextFactory#create}} but this is WRONG since recovery/resume path skips this code (on account that it should contain the DStreamGraph creation only, which is checkpointed).
> In order any StreamingListener to recover they are probably better of here: https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunner.java#L171 


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)