Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0A4C1200C22 for ; Tue, 7 Feb 2017 00:13:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 08CF8160B56; Mon, 6 Feb 2017 23:13:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5D746160B64 for ; Tue, 7 Feb 2017 00:13:47 +0100 (CET) Received: (qmail 92201 invoked by uid 500); 6 Feb 2017 23:13:46 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 92192 invoked by uid 99); 6 Feb 2017 23:13:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2017 23:13:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5EEC0180028 for ; Mon, 6 Feb 2017 23:13:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id oQCwrrxtxSe1 for ; Mon, 6 Feb 2017 23:13:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id ABC185F5C7 for ; Mon, 6 Feb 2017 23:13:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0A21CE0146 for ; Mon, 6 Feb 2017 23:13:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BD0782528B for ; Mon, 6 Feb 2017 23:13:41 +0000 (UTC) Date: Mon, 6 Feb 2017 23:13:41 +0000 (UTC) From: "Andy Xu (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-1408) outputWithTimestamp() accepts timestamps that will fail preconditions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 06 Feb 2017 23:13:48 -0000 Andy Xu created BEAM-1408: ----------------------------- Summary: outputWithTimestamp() accepts timestamps that will fail preconditions Key: BEAM-1408 URL: https://issues.apache.org/jira/browse/BEAM-1408 Project: Beam Issue Type: Improvement Components: sdk-java-core Reporter: Andy Xu Assignee: Davor Bonaci Priority: Minor We have accidentally created events with *wrong* timestamps in the future which are accepted by outputWithTimestamp(), but will fail at a later step: java.lang.IllegalStateException: Timer 472976-06-15T20:09:57.269Z is beyond end-of-time atcom.google.cloud.dataflow.sdk.repackaged.com.google.common.base.Preconditions.checkState(Preconditions.java:199) at com.google.cloud.dataflow.sdk.util.ReduceFnRunner.scheduleEndOfWindowOrGarbageCollectionTimer(ReduceFnRunner.java:1050) [...] Would it make sense to implement a check already at outputWithTimestamp() level to fail early? -- This message was sent by Atlassian JIRA (v6.3.15#6346)