Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B3677200C1A for ; Mon, 13 Feb 2017 22:16:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B2390160B6C; Mon, 13 Feb 2017 21:16:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0E98A160B4A for ; Mon, 13 Feb 2017 22:16:46 +0100 (CET) Received: (qmail 96150 invoked by uid 500); 13 Feb 2017 21:16:46 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 96107 invoked by uid 99); 13 Feb 2017 21:16:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 21:16:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D1ECDC040B for ; Mon, 13 Feb 2017 21:16:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id N24q5_pbcrDe for ; Mon, 13 Feb 2017 21:16:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 97C605FB44 for ; Mon, 13 Feb 2017 21:16:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 822A1E0647 for ; Mon, 13 Feb 2017 21:16:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DD81421D6A for ; Mon, 13 Feb 2017 21:16:41 +0000 (UTC) Date: Mon, 13 Feb 2017 21:16:41 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1346) Drop Late Data in ReduceFnRunner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Feb 2017 21:16:47 -0000 [ https://issues.apache.org/jira/browse/BEAM-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864437#comment-15864437 ] Kenneth Knowles commented on BEAM-1346: --------------------------------------- I agree with your paranoia. This is related to BEAM-696. I think {{PushbackSideInputRunner}} is technically OK because it pushes all the complexity to the runner. The runner can provide a {{ReadyCheckingSideInputReader}} that understands the merging, and the runner decides when to wake up the processing and feed the pushed-back elements, so it can alter its timers, etc, according to merging. And if this is all too complex, maybe the runner can [disable any troublesome optimizations|https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java#L811] for now. > Drop Late Data in ReduceFnRunner > -------------------------------- > > Key: BEAM-1346 > URL: https://issues.apache.org/jira/browse/BEAM-1346 > Project: Beam > Issue Type: Bug > Components: runner-core > Affects Versions: 0.5.0 > Reporter: Aljoscha Krettek > > I think these two commits recently broke late-data dropping for the Flink Runner (and maybe for other runners as well): > - https://github.com/apache/beam/commit/2b26ec8 > - https://github.com/apache/beam/commit/8989473 > It boils down to the {{LateDataDroppingDoFnRunner}} not being used anymore because {{DoFnRunners.lateDataDroppingRunner()}} is not called anymore when a {{DoFn}} is a {{ReduceFnExecutor}} (because that interface was removed). > Maybe we should think about dropping late data in another place, my suggestion is {{ReduceFnRunner}} but that's open for discussion. -- This message was sent by Atlassian JIRA (v6.3.15#6346)