Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7C875200C1D for ; Thu, 2 Feb 2017 02:20:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7B149160B5E; Thu, 2 Feb 2017 01:20:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C43A0160B46 for ; Thu, 2 Feb 2017 02:20:55 +0100 (CET) Received: (qmail 74747 invoked by uid 500); 2 Feb 2017 01:20:55 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 74738 invoked by uid 99); 2 Feb 2017 01:20:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 01:20:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9B6CB1A015E for ; Thu, 2 Feb 2017 01:20:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qSKQgmaAmYCE for ; Thu, 2 Feb 2017 01:20:53 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F39D85FBBD for ; Thu, 2 Feb 2017 01:20:52 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C1509E023B for ; Thu, 2 Feb 2017 01:20:51 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7FF602528A for ; Thu, 2 Feb 2017 01:20:51 +0000 (UTC) Date: Thu, 2 Feb 2017 01:20:51 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1334) Split UsesMetrics category and tests into UsesCommittedMetrics and UsesAttemptedMetrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 02 Feb 2017 01:20:56 -0000 [ https://issues.apache.org/jira/browse/BEAM-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849227#comment-15849227 ] ASF GitHub Bot commented on BEAM-1334: -------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/beam/pull/1865 > Split UsesMetrics category and tests into UsesCommittedMetrics and UsesAttemptedMetrics > --------------------------------------------------------------------------------------- > > Key: BEAM-1334 > URL: https://issues.apache.org/jira/browse/BEAM-1334 > Project: Beam > Issue Type: Task > Components: sdk-java-core > Reporter: Aviem Zur > Assignee: Aviem Zur > Priority: Minor > > Some runners may not be able to implement both {{committed}} and {{attempted}} results in {{MetricResult}}. > Seeing this, split the current {{RunnableOnService}} test {{org.apache.beam.sdk.metrics.MetricsTest#metricsReportToQuery}} into two tests, which test attempted and committed results separately with categories {{UsesCommittedMetrics}} and {{UsesAttemptedMetrics}} instead of the current category {{UsesMetrics}}. > Discussion that led to this can be seen in the this [PR|https://github.com/apache/beam/pull/1750#issuecomment-275412984] -- This message was sent by Atlassian JIRA (v6.3.15#6346)