Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Wed, 1 Feb 2017 18:37:51 +0000 (UTC)
From: "Daniel Halperin (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13025934.1481022483000.9712.1485974271762@Atlassian.JIRA>
In-Reply-To: <JIRA.13025934.1481022483000@Atlassian.JIRA>
References: <JIRA.13025934.1481022483000@Atlassian.JIRA> <JIRA.13025934.1481022483473@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-1092) Shade commonly used libraries (e.g.
 Guava) to avoid class conflicts
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 01 Feb 2017 18:37:57 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848754#comment-15848754 ] 

Daniel Halperin commented on BEAM-1092:
---------------------------------------

[~aviemzur] I strongly agree that we should move to aggressive shading where we can. Send a PR for KafkaIO module?

> Shade commonly used libraries (e.g. Guava) to avoid class conflicts
> -------------------------------------------------------------------
>
>                 Key: BEAM-1092
>                 URL: https://issues.apache.org/jira/browse/BEAM-1092
>             Project: Beam
>          Issue Type: Bug
>          Components: examples-java, sdk-java-extensions
>    Affects Versions: 0.3.0-incubating
>            Reporter: Maximilian Michels
>            Assignee: Frances Perry
>
> Beam shades away some of its dependencies like Guava to avoid user classes from clashing with these dependencies. Some of the artifacts, e.g. KafkaIO, do not shade any classes and directly depend on potentially conflicting libraries (e.g. Guava). Also, users might manually add such libraries as dependencies.
> Runners who add classes to the classpath (e.g. Hadoop) can run into conflict with multiple versions of the same class. To prevent that, we should adjust the Maven archetypes pom files used for the Quickstart to perform shading of commonly used libraries (again, Guava is often the culprit).
> To prevent the problem in the first place, we should expand the shading of Guava and other libraries to all modules which make use of these. 
> To solve both dimensions of the issue, we need to address:
> 1. Adding shading of commonly used libraries to the archetypes poms
> 2. Properly shade all commonly used libraries in the SDK modules
> 2) seems to be of highest priority since it affects users who simply use the provided IO modules.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)