Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Tue, 21 Feb 2017 17:56:44 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.incubator.apache.org
Message-ID: <JIRA.13006263.1474396117000.20495.1487699804229@Atlassian.JIRA>
In-Reply-To: <JIRA.13006263.1474396117000@Atlassian.JIRA>
References: <JIRA.13006263.1474396117000@Atlassian.JIRA> <JIRA.13006263.1474396117731@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-646) Get runners out of the apply()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 21 Feb 2017 17:56:49 -0000


    [ https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876397#comment-15876397 ] 

ASF GitHub Bot commented on BEAM-646:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2055

    [BEAM-646] Add a Base OverrideFactory class for 1-to-1 overrides

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    These overrides are relatively common, and this reduces the
    reimplementation of mapping singletons and casting them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam one-to-one_overrides

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2055.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2055
    
----
commit 1f15eba04c034e49feb34ff2b1ae8b7ff79268e9
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-17T03:14:23Z

    Add a Base OverrideFactory class for 1-to-1 overrides
    
    These overrides are relatively common, and this reduces the
    reimplementation of mapping singletons and casting them.

commit 2577f0b491b284a1a7c65b562b80614ff888050e
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-21T17:55:47Z

    Migrate DirectRunner one-to-one factories
    
    Use SingleInputOutputOverrideFactory to reduce prevalence of
    boilerplate.

----


> Get runners out of the apply()
> ------------------------------
>
>                 Key: BEAM-646
>                 URL: https://issues.apache.org/jira/browse/BEAM-646
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model-runner-api, sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>              Labels: backwards-incompatible
>
> Right now, the runner intercepts calls to apply() and replaces transforms as we go. This means that there is no "original" user graph. For portability and misc architectural benefits, we would like to build the original graph first, and have the runner override later.
> Some runners already work in this manner, but we could integrate it more smoothly, with more validation, via some handy APIs on e.g. the Pipeline object.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)