beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2078: [BEAM-646] Specialize ISM View Translations
Date Wed, 22 Feb 2017 23:02:50 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2078

    [BEAM-646] Specialize ISM View Translations

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    These translations have a different coder than the original view, which
    is required on the worker side to be transmitted as part of the
    Singleton Output, and are generally not compatible with the replacements
    performed during Pipeline Surgery. Specializing this translation allows
    the updated coders to be set on the output view based on the overriding
    transform, rather than the output node, as the view needs to remain
    consistent.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam ism_coder_specialized_override

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2078.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2078
    
----
commit 519e8f2495f9463119f190a29e53c8398cb7ec7e
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-22T22:59:08Z

    Specialize ISM View Translations
    
    These translations have a different coder than the original view, which
    is required on the worker side to be transmitted as part of the
    Singleton Output, and are generally not compatible with the replacements
    performed during Pipeline Surgery. Specializing this translation allows
    the updated coders to be set on the output view based on the overriding
    transform, rather than the output node, as the view needs to remain
    consistent.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message