beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #2019: Remove Unneccessary DataflowRunner Overrides
Date Thu, 16 Feb 2017 17:16:32 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2019

    Remove Unneccessary DataflowRunner Overrides

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    The removed overrides are indistinguishable from the transform that they
    are overriding.
    
    This is separated mainly to make sure the surgery-based implementation
    doesn't mysteriously remove overrides when it's easier to handle as 1-to-1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam remove_redundant_overrides

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2019
    
----
commit e9d66faa1637aa0e72c9137c303855eed36d4e87
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-16T17:14:47Z

    Remove Unneccessary DataflowRunner Overrides
    
    The removed overrides are indistinguishable from the transform that they
    are overriding.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message