beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <...@git.apache.org>
Subject [GitHub] beam pull request #1997: [BEAM-1280] Remove passing label from Combiners
Date Mon, 13 Feb 2017 18:57:55 GMT
GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/1997

    [BEAM-1280] Remove passing label from Combiners

    R: @aaltay PTAL
    
    After this only assert_that and AsSingleton etc for SideInputs take the label as the argument.
Rest should be gone.
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-1280-remove-label-from-combiners

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1997.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1997
    
----
commit 5abfbf9300bada36adc7c55b0c2fe21a66215b67
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Date:   2017-02-13T16:48:18Z

    Remove passing label from Combiners

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message