beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #1971: [BEAM-646] Construct Pipeline Nodes after Pipeline#...
Date Fri, 10 Feb 2017 01:50:23 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/1971

    [BEAM-646] Construct Pipeline Nodes after Pipeline#run

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Before-run is not compatible with Pipeline Surgery
    
    Specifically, before-execution fails because the snapshot that is taken of the Pipeline
is before the PipelineRunner replaces all the nodes, and as a result the final graph (after
run() and the test complete successfully) has different nodes, even though it is (in terms
of pipeline behavior) the same graph. Neither of the TestPipeline Enforcements require a pre-run
traversal, so this should not have observable effects outside of surgery.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam test_pipeline_sequencing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1971.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1971
    
----
commit af403d7d1b2cd4a404d882f8a3300b7558f4c3f1
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-09T19:39:08Z

    Construct Pipeline Nodes after Pipeline#run
    
    Before-run is not compatible with Pipeline Surgery

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message