beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #1957: [BEAM-440] Add Create#empty
Date Thu, 09 Feb 2017 01:00:25 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/1957

    [BEAM-440] Add Create#empty

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This replaces #843, which appears to be abandoned.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam create_empty

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1957
    
----
commit 9d9080a97050712845a31b777d1f739602e09e43
Author: Jason White <jason.white@shopify.com>
Date:   2016-08-16T23:35:47Z

    add Create#empty

commit 65818bb0daf81826a015ce1008a0891491fab818
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-09T00:56:49Z

    Replace Create.of(T...) with Create.of(T, T...)
    
    This ensures that an empty Create must go through either
    Create.empty(Coder) or Create.of(Iterable<T>). Enforce the non-emptiness
    of the elements iterable with no coder.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message