beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sb2nov <...@git.apache.org>
Subject [GitHub] beam pull request #1942: [BEAM-1429] WindowFn assign should not access the w...
Date Wed, 08 Feb 2017 00:03:24 GMT
GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/1942

    [BEAM-1429] WindowFn assign should not access the window set

    https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/window.py#L97
does not really use access to multiple windows at the same time.
    
    Also as we move to the NewDoFn we have moved away from accessing the windowSet together.
Change the function here to only take the element and timestamp as the input.
    
    R: @robertwb @aaltay  PTAL
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/beam BEAM-1429-window_assign_timestamp_element

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1942
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message