beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From al...@apache.org
Subject [1/2] beam git commit: Remove references to PipelineRunner
Date Fri, 10 Feb 2017 23:54:41 GMT
Repository: beam
Updated Branches:
  refs/heads/master aac4da171 -> 65af217a6


Remove references to PipelineRunner


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/c4b4a4ae
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/c4b4a4ae
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/c4b4a4ae

Branch: refs/heads/master
Commit: c4b4a4ae04fb15914eed8ae721ba4f7a6f333744
Parents: aac4da1
Author: Sourabh Bajaj <sourabhbajaj@google.com>
Authored: Fri Feb 10 14:06:33 2017 -0800
Committer: Ahmet Altay <altay@google.com>
Committed: Fri Feb 10 15:54:05 2017 -0800

----------------------------------------------------------------------
 sdks/python/apache_beam/runners/runner.py      | 8 --------
 sdks/python/apache_beam/runners/runner_test.py | 6 ------
 2 files changed, 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/c4b4a4ae/sdks/python/apache_beam/runners/runner.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/runners/runner.py b/sdks/python/apache_beam/runners/runner.py
index 8cbcf65..cf75a2b 100644
--- a/sdks/python/apache_beam/runners/runner.py
+++ b/sdks/python/apache_beam/runners/runner.py
@@ -47,14 +47,6 @@ def create_runner(runner_name):
     RuntimeError: if an invalid runner name is used.
   """
 
-  # TODO(BEAM-1185): Remove when all references to PipelineRunners are gone.
-  if 'PipelineRunner' in runner_name:
-    new_runner_name = runner_name.replace('PipelineRunner', 'Runner')
-    if new_runner_name in _ALL_KNOWN_RUNNERS:
-      logging.warning(
-          '%s is deprecated, use %s instead.', runner_name, new_runner_name)
-      runner_name = new_runner_name
-
   if runner_name in _KNOWN_DIRECT_RUNNERS:
     runner_name = 'apache_beam.runners.direct.direct_runner.' + runner_name
   elif runner_name in _KNOWN_DATAFLOW_RUNNERS:

http://git-wip-us.apache.org/repos/asf/beam/blob/c4b4a4ae/sdks/python/apache_beam/runners/runner_test.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/runners/runner_test.py b/sdks/python/apache_beam/runners/runner_test.py
index 88807b8..ef2b994 100644
--- a/sdks/python/apache_beam/runners/runner_test.py
+++ b/sdks/python/apache_beam/runners/runner_test.py
@@ -66,12 +66,6 @@ class RunnerTest(unittest.TestCase):
         isinstance(create_runner('TestDataflowRunner'),
                    TestDataflowRunner))
     self.assertRaises(ValueError, create_runner, 'xyz')
-    # TODO(BEAM-1185): Remove when all references to PipelineRunners are gone.
-    self.assertTrue(
-        isinstance(create_runner('DirectPipelineRunner'), DirectRunner))
-    self.assertTrue(
-        isinstance(create_runner('DataflowPipelineRunner'),
-                   DataflowRunner))
 
   def test_remote_runner_translation(self):
     remote_runner = DataflowRunner()


Mime
View raw message