beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Halperin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1567) hashStream should be closed in PackageUtil#createPackageAttributes()
Date Mon, 27 Feb 2017 20:14:45 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886456#comment-15886456
] 

Daniel Halperin commented on BEAM-1567:
---------------------------------------

Thanks [~tedyu@apache.org],

This indeed looks like it could be an issue. We may be getting lucky that none of the intermediate
structures buffer data today, but this should be fixed.

* Can I ask how you found this?
* Would you be able to send a PR to fix?

Thanks!

> hashStream should be closed in PackageUtil#createPackageAttributes()
> --------------------------------------------------------------------
>
>                 Key: BEAM-1567
>                 URL: https://issues.apache.org/jira/browse/BEAM-1567
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Ted Yu
>            Assignee: Davor Bonaci
>            Priority: Minor
>
> Here is related code:
> {code}
>       OutputStream hashStream = Funnels.asOutputStream(hasher);
> {code}
> hashStream should be closed upon return from the method



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message