beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1548) Window should not reassign windows if no WindowFn is specified
Date Fri, 24 Feb 2017 19:31:44 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883381#comment-15883381
] 

ASF GitHub Bot commented on BEAM-1548:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2101

    [BEAM-1548] Do not Reassign Windows when WindowFn is null

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Adjusting the Windowing Strategy should not change any elements of the
    data.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam assign_windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2101
    
----
commit 78053d50d5728e6c17bea48dbbe7598cc0add5da
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-24T19:29:42Z

    Do not Reassign Windows when WindowFn is null
    
    Adjusting the Windowing Strategy should not change any elements of the
    data.

----


> Window should not reassign windows if no WindowFn is specified
> --------------------------------------------------------------
>
>                 Key: BEAM-1548
>                 URL: https://issues.apache.org/jira/browse/BEAM-1548
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message