beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1523) Remove PValue.getProducingTransformInternal
Date Tue, 21 Feb 2017 22:06:44 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876831#comment-15876831
] 

ASF GitHub Bot commented on BEAM-1523:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/2058

    [BEAM-1523] Remove PValue.getProducingTransformInternal

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    This exposes too much information on the structure of the Graph to be
    appropriate for non-graph related APIs. It also is not stable, and
    subject to change at any point due to Pipeline Surgery APIs.
    
    Update DataflowRunner to use the visited TransformHierarchy to obtain
    the producing transforms for PValues, and store these values to
    construct the graph.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam remove_get_producing_transform_internal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2058.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2058
    
----
commit f13bac4de499d72816037f287e1e8c6f6bf89364
Author: Thomas Groh <tgroh@google.com>
Date:   2017-02-21T21:55:23Z

    Remove PValue.getProducingTransformInternal
    
    This exposes too much information on the structure of the Graph to be
    appropriate for non-graph related APIs. It also is not stable, and
    subject to change at any point due to Pipeline Surgery APIs.
    
    Update DataflowRunner to use the visited TransformHierarchy to obtain
    the producing transforms for PValues, and store these values to
    construct the graph.

----


> Remove PValue.getProducingTransformInternal
> -------------------------------------------
>
>                 Key: BEAM-1523
>                 URL: https://issues.apache.org/jira/browse/BEAM-1523
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> This method exposes graph structure which is not guaranteed to be stable, and should
not be used directly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message