beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-1513) Skip slower verifications if '-DskipTests' specified
Date Sun, 19 Feb 2017 20:26:44 GMT

    [ https://issues.apache.org/jira/browse/BEAM-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873830#comment-15873830
] 

ASF GitHub Bot commented on BEAM-1513:
--------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/beam/pull/2048

    [BEAM-1513] Skip slower verifications if '-DskipTests' specified

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/beam skip-slow-verifications

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2048.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2048
    
----
commit 86d42a6b0cc4d4322017bc5b004e74097728b9e9
Author: Aviem Zur <aviemzur@gmail.com>
Date:   2017-02-19T20:24:14Z

    [BEAM-1513] Skip slower verifications if '-DskipTests' specified

----


> Skip slower verifications if '-DskipTests' specified
> ----------------------------------------------------
>
>                 Key: BEAM-1513
>                 URL: https://issues.apache.org/jira/browse/BEAM-1513
>             Project: Beam
>          Issue Type: Improvement
>          Components: build-system
>            Reporter: Aviem Zur
>            Assignee: Aviem Zur
>            Priority: Minor
>
> Skip slower verifications (checkstyle, rat and findbugs) if '-DskipTests' was specified
in the maven command. Enable them otherwise.
> The reasoning behind this is usually if you're skipping tests you're in a hurry to build
and do not want to go through the slower verifications.
> Should still be able to force these verifications with '-Prelease' as before, even if
'-DskipTests' is specified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message